[
https://issues.apache.org/jira/browse/HDFS-16457?focusedWorklogId=753175&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753175
]
ASF GitHub Bot logged work on HDFS-16457:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/22 02:20
Start Date: 06/Apr/22 02:20
Worklog Time Spent: 10m
Work Description: singer-bin commented on code in PR #4069:
URL: https://github.com/apache/hadoop/pull/4069#discussion_r843403737
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##########
@@ -891,13 +896,25 @@ private String reconfDfsUsageParameters(String property,
String newVal)
for (FsVolumeImpl fsVolume : volumeList) {
Map<String, BlockPoolSlice> blockPoolSlices =
fsVolume.getBlockPoolSlices();
for (BlockPoolSlice value : blockPoolSlices.values()) {
- value.updateDfsUsageConfig(null, jitter);
+ value.updateDfsUsageConfig(null, jitter, null);
+ }
+ }
+ } else if (property.equals(FS_GETSPACEUSED_CLASSNAME)) {
+ Preconditions.checkNotNull(data, "FsDatasetSpi has not been
initialized.");
+ Class<? extends GetSpaceUsed> klass = (newVal == null ? DU.class :
+ Class.forName(newVal).asSubclass(GetSpaceUsed.class));
Review Comment:
Thank you very much for your review, I will revise it right away. @tasanuma
Issue Time Tracking
-------------------
Worklog Id: (was: 753175)
Time Spent: 4h 40m (was: 4.5h)
> Make fs.getspaceused.classname reconfigurable
> ---------------------------------------------
>
> Key: HDFS-16457
> URL: https://issues.apache.org/jira/browse/HDFS-16457
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.3.0
> Reporter: yanbin.zhang
> Assignee: yanbin.zhang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Now if we want to switch fs.getspaceused.classname we need to restart the
> NameNode. It would be convenient if we can switch it at runtime.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
