[
https://issues.apache.org/jira/browse/HDFS-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190194#comment-13190194
]
Hadoop QA commented on HDFS-2786:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12511325/hdfs-2786.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated 21 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1792//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1792//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1792//console
This message is automatically generated.
> Fix host-based token incompatibilities in DFSUtil
> -------------------------------------------------
>
> Key: HDFS-2786
> URL: https://issues.apache.org/jira/browse/HDFS-2786
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node, security
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Daryn Sharp
> Assignee: Kihwal Lee
> Attachments: hdfs-2786.patch
>
>
> DFSUtil introduces new static methods that duplicate functionality in
> NetUtils. These new methods lack the logic necessary for host-based tokens
> to work. After speaking with Suresh, the approach being taken is:
> * DFSUtil.getSocketAddress will be removed. Callers will be reverted to
> using the NetUtils version.
> * DFSUtil.getDFSClient will changed to take accept a uri/host:port string
> instead of an InetSocketAddress. The method will internal call
> NetUtils.createSocketAddr. This alleviates the callers from being required to
> call NetUtils.createSocketAddr and reduce the opportunity for error that will
> break host-based tokens.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
