[
https://issues.apache.org/jira/browse/HDFS-16680?focusedWorklogId=794317&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794317
]
ASF GitHub Bot logged work on HDFS-16680:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/22 17:15
Start Date: 22/Jul/22 17:15
Worklog Time Spent: 10m
Work Description: GauthamBanasandra opened a new pull request, #4611:
URL: https://github.com/apache/hadoop/pull/4611
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
The CMake test `libhdfs_mini_stress_valgrind` requires Valgrind -
https://github.com/apache/hadoop/blob/221eb2d68d5b52e4394fd36cb30d5ee9ffeea7f0/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/CMakeLists.txt#L172-L175
We need to skip this test on Windows since we don't have Valgrind on Windows.
### How was this patch tested?
1. Tested this locally by building on my Windows system.
2. Hadoop Jenkins CI validation.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
Issue Time Tracking
-------------------
Worklog Id: (was: 794317)
Remaining Estimate: 0h
Time Spent: 10m
> Skip libhdfspp Valgrind tests on Windows
> ----------------------------------------
>
> Key: HDFS-16680
> URL: https://issues.apache.org/jira/browse/HDFS-16680
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs++
> Affects Versions: 3.4.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The CMake test libhdfs_mini_stress_valgrind requires Valgrind -
> https://github.com/apache/hadoop/blob/221eb2d68d5b52e4394fd36cb30d5ee9ffeea7f0/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/CMakeLists.txt#L172-L175
> {code}
> build_libhdfs_test(libhdfs_mini_stress_valgrind hdfspp_test_static expect.c
> test_libhdfs_mini_stress.c ${OS_DIR}/thread.c)
> link_libhdfs_test(libhdfs_mini_stress_valgrind hdfspp_test_static fs reader
> rpc proto common connection ${PROTOBUF_LIBRARIES} ${OPENSSL_LIBRARIES}
> native_mini_dfs ${JAVA_JVM_LIBRARY} ${SASL_LIBRARIES})
> add_memcheck_test(libhdfs_mini_stress_valgrind_hdfspp_test_static
> libhdfs_mini_stress_valgrind_hdfspp_test_static)
> set_target_properties(libhdfs_mini_stress_valgrind_hdfspp_test_static
> PROPERTIES COMPILE_DEFINITIONS "VALGRIND")
> {code}
> We need to skip this test on Windows since we don't have Valgrind on Windows.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
