[ https://issues.apache.org/jira/browse/HDFS-16680?focusedWorklogId=794469&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794469 ]
ASF GitHub Bot logged work on HDFS-16680: ----------------------------------------- Author: ASF GitHub Bot Created on: 23/Jul/22 09:35 Start Date: 23/Jul/22 09:35 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4611: URL: https://github.com/apache/hadoop/pull/4611#issuecomment-1193095447 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 26m 25s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 25m 32s | | trunk passed | | +1 :green_heart: | compile | 4m 10s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 51s | | trunk passed | | +1 :green_heart: | shadedclient | 52m 54s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 25s | | the patch passed | | +1 :green_heart: | compile | 3m 55s | | the patch passed | | +1 :green_heart: | cc | 3m 56s | | the patch passed | | +1 :green_heart: | javac | 3m 55s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | mvnsite | 0m 27s | | the patch passed | | +1 :green_heart: | shadedclient | 22m 9s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 85m 24s | | hadoop-hdfs-native-client in the patch passed. | | +1 :green_heart: | asflicense | 0m 49s | | The patch does not generate ASF License warnings. | | | | 195m 10s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4611 | | Optional Tests | dupname asflicense compile cc mvnsite javac unit codespell detsecrets | | uname | Linux 2ece93393ca8 4.15.0-184-generic #194-Ubuntu SMP Thu Jun 2 18:54:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / cde1b621b261dd0784cb892a84840744054096f2 | | Default Java | Red Hat, Inc.-1.8.0_312-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/testReport/ | | Max. process+thread count | 593 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/console | | versions | git=2.27.0 maven=3.6.3 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. Issue Time Tracking ------------------- Worklog Id: (was: 794469) Time Spent: 40m (was: 0.5h) > Skip libhdfspp Valgrind tests on Windows > ---------------------------------------- > > Key: HDFS-16680 > URL: https://issues.apache.org/jira/browse/HDFS-16680 > Project: Hadoop HDFS > Issue Type: Bug > Components: libhdfs++ > Affects Versions: 3.4.0 > Environment: Windows 10 > Reporter: Gautham Banasandra > Assignee: Gautham Banasandra > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > The CMake test libhdfs_mini_stress_valgrind requires Valgrind - > https://github.com/apache/hadoop/blob/221eb2d68d5b52e4394fd36cb30d5ee9ffeea7f0/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/CMakeLists.txt#L172-L175 > {code} > build_libhdfs_test(libhdfs_mini_stress_valgrind hdfspp_test_static expect.c > test_libhdfs_mini_stress.c ${OS_DIR}/thread.c) > link_libhdfs_test(libhdfs_mini_stress_valgrind hdfspp_test_static fs reader > rpc proto common connection ${PROTOBUF_LIBRARIES} ${OPENSSL_LIBRARIES} > native_mini_dfs ${JAVA_JVM_LIBRARY} ${SASL_LIBRARIES}) > add_memcheck_test(libhdfs_mini_stress_valgrind_hdfspp_test_static > libhdfs_mini_stress_valgrind_hdfspp_test_static) > set_target_properties(libhdfs_mini_stress_valgrind_hdfspp_test_static > PROPERTIES COMPILE_DEFINITIONS "VALGRIND") > {code} > We need to skip this test on Windows since we don't have Valgrind on Windows. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org