[ https://issues.apache.org/jira/browse/HDFS-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709464#comment-17709464 ]
ASF GitHub Bot commented on HDFS-16971: --------------------------------------- rdingankar commented on code in PR #5536: URL: https://github.com/apache/hadoop/pull/5536#discussion_r1160063449 ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ########## @@ -3942,6 +3942,7 @@ public static class StatisticsData { private volatile long bytesReadDistanceOfThreeOrFour; private volatile long bytesReadDistanceOfFiveOrLarger; private volatile long bytesReadErasureCoded; + private volatile long remoteBytesReadTime; Review Comment: Can we rename to include unit of time in the variable? `remoteBytesReadTimeSecs` or `remoteBytesReadTimeMS` ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ########## @@ -4252,6 +4259,14 @@ public void incrementBytesReadByDistance(int distance, long newBytes) { } } + /** + * Increment the time taken to read bytes from remote in the statistics. + * @param duration time taken to read bytes from remote Review Comment: mention the unit of duration > Add read time metrics for remote reads in Statistics > ---------------------------------------------------- > > Key: HDFS-16971 > URL: https://issues.apache.org/jira/browse/HDFS-16971 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs > Reporter: Melissa You > Priority: Minor > Labels: pull-request-available > Fix For: 3.3.0, 3.4.0 > > > In Filesystem.java, currently it only collects bytes read not the > corresponding timing of reads. > In particular, we're interested in time spent on remote reads(not local > reads). Adding timing info will help us understand it better and further > analyze how locality of DN behaves. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org