[ https://issues.apache.org/jira/browse/HDFS-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711151#comment-17711151 ]
ASF GitHub Bot commented on HDFS-16971: --------------------------------------- melissayou commented on code in PR #5536: URL: https://github.com/apache/hadoop/pull/5536#discussion_r1163448235 ########## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java: ########## @@ -3090,10 +3090,14 @@ public Peer newConnectedPeer(InetSocketAddress addr, } } - void updateFileSystemReadStats(int distance, int nRead) { + void updateFileSystemReadStats(int distance, int nRead, long readTimeMS) { Review Comment: nRead is the readBytes, do you feel `readBytes` is better than the original `nRead`? > Add read time metrics for remote reads in Statistics > ---------------------------------------------------- > > Key: HDFS-16971 > URL: https://issues.apache.org/jira/browse/HDFS-16971 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs > Reporter: Melissa You > Priority: Minor > Labels: pull-request-available > Fix For: 3.3.0, 3.4.0 > > > In Filesystem.java, currently it only collects bytes read not the > corresponding timing of reads. > In particular, we're interested in time spent on remote reads(not local > reads). Adding timing info will help us understand it better and further > analyze how locality of DN behaves. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org