[ 
https://issues.apache.org/jira/browse/HDFS-17023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725173#comment-17725173
 ] 

ASF GitHub Bot commented on HDFS-17023:
---------------------------------------

hfutatzhanghb commented on PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1558469632

   > 
   
   @ayushtkn , Sir, thanks for your reviewing. I am so sorry about forcing 
push.  The failed unit tests is related to my modification. The reason is 
proxyOpComplete method must need a non-null nsID param, however i pass null to 
it.  I am fixing this problem and add unit tests for this PR.




> RBF: Record proxy time when call invokeConcurrent method.
> ---------------------------------------------------------
>
>                 Key: HDFS-17023
>                 URL: https://issues.apache.org/jira/browse/HDFS-17023
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf
>    Affects Versions: 3.3.4
>            Reporter: farmmamba
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently, we only invoke below code snippet in invokeConcurrent method.
> {code:java}
> if (rpcMonitor != null) {
>   rpcMonitor.proxyOp();
> } {code}
> Whether should we invoke `proxyOpComplete` method like what invokeMethod does 
> or not?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to