[
https://issues.apache.org/jira/browse/HDFS-17023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725339#comment-17725339
]
ASF GitHub Bot commented on HDFS-17023:
---------------------------------------
hfutatzhanghb commented on PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1558985527
> if it is correct, everything is good then, we can close this
Sir, i think we still need to add proxyOpComplete here. The reason is that
we lack monitoring of invokeConcurrent proxyOps and proxyTime currently. We
need to know the time for the router to proxy an operation to the all
nameservices, we can use this time to discover performance problems of RPCs
using invokeConcurrent.
> RBF: Record proxy time when call invokeConcurrent method.
> ---------------------------------------------------------
>
> Key: HDFS-17023
> URL: https://issues.apache.org/jira/browse/HDFS-17023
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Affects Versions: 3.3.4
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Minor
> Labels: pull-request-available
>
> Currently, we only invoke below code snippet in invokeConcurrent method.
> {code:java}
> if (rpcMonitor != null) {
> rpcMonitor.proxyOp();
> } {code}
> Whether should we invoke `proxyOpComplete` method like what invokeMethod does
> or not?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
