[ https://issues.apache.org/jira/browse/HDFS-17068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741272#comment-17741272 ]
ASF GitHub Bot commented on HDFS-17068: --------------------------------------- hfutatzhanghb commented on code in PR #5809: URL: https://github.com/apache/hadoop/pull/5809#discussion_r1257219915 ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java: ########## @@ -477,4 +482,7 @@ public MountVolumeMap getMountVolumeMap() { public List<FsVolumeImpl> getVolumeList() { return null; } + + @Override + public void setLastDirScannerFinishTime(long time) {} Review Comment: @xinglin Hi, sir. I do not know why exacltly, but i think the SimulatedFSDataset is just for simplifing test. if we make both behave the same way, there is no need to have class SimulatedFSDataset. What's your idea?Thanks a lot. ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java: ########## @@ -477,4 +482,7 @@ public MountVolumeMap getMountVolumeMap() { public List<FsVolumeImpl> getVolumeList() { return null; } + + @Override + public void setLastDirScannerFinishTime(long time) {} Review Comment: @xinglin Hi, sir. I do not know why exacltly, but i think the SimulatedFSDataset is just for simplifing test. if we make both behave the same way, there is no need to have class SimulatedFSDataset. What's your idea?Thanks a lot. > Datanode should record last directory scan time. > ------------------------------------------------ > > Key: HDFS-17068 > URL: https://issues.apache.org/jira/browse/HDFS-17068 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: farmmamba > Assignee: farmmamba > Priority: Minor > Labels: pull-request-available > > I think it is useful for us to record last directory scan time for one > datanode. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org