[ https://issues.apache.org/jira/browse/HDFS-17068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741427#comment-17741427 ]
ASF GitHub Bot commented on HDFS-17068: --------------------------------------- xinglin commented on code in PR #5809: URL: https://github.com/apache/hadoop/pull/5809#discussion_r1257544818 ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java: ########## @@ -53,6 +53,7 @@ public class ExternalDatasetImpl implements FsDatasetSpi<ExternalVolumeImpl> { private final DatanodeStorage storage = new DatanodeStorage( DatanodeStorage.generateUuid(), DatanodeStorage.State.NORMAL, StorageType.DEFAULT); + private long lastDirScannerFinishTime; Review Comment: A lot of functions in this class are not implemented. I think we should following the same pattern here. getLastDirScannerFinishTime() -> return 0. setLastDirScannerFinishTime() -> do nothing. Below are functions related with Trash. ``` @Override public void enableTrash(String bpid) { } @Override public void clearTrash(String bpid) { } @Override public boolean trashEnabled(String bpid) { return false; } ``` `SimulatedFSDataset.java `has a different implementation for enableTrash(). So, I guess we don't have to enforce the same implementation between `SimulatedFSDataset` and `ExternalDatasetImpl`. I am fine with the current change. ``` @Override public void enableTrash(String bpid) { throw new UnsupportedOperationException(); } ``` > Datanode should record last directory scan time. > ------------------------------------------------ > > Key: HDFS-17068 > URL: https://issues.apache.org/jira/browse/HDFS-17068 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: farmmamba > Assignee: farmmamba > Priority: Minor > Labels: pull-request-available > > I think it is useful for us to record last directory scan time for one > datanode. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org