[
https://issues.apache.org/jira/browse/HDFS-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752639#comment-17752639
]
ASF GitHub Bot commented on HDFS-17140:
---------------------------------------
slfan1989 commented on PR #5924:
URL: https://github.com/apache/hadoop/pull/5924#issuecomment-1672614747
> @Hexiaoqiao @slfan1989 This improvement may not have much effect, but it
does reduce the creation of redundant and useless temporary objects. At the
same time, from the perspective of code style, the implementation here is not
elegant.
@Hexiaoqiao Thank you very much for your explanation, I have understood this
change and can accept it, thank you again for your contribution!
> Optimize the BPOfferService.reportBadBlocks() method
> ----------------------------------------------------
>
> Key: HDFS-17140
> URL: https://issues.apache.org/jira/browse/HDFS-17140
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Liangjun He
> Assignee: Liangjun He
> Priority: Minor
> Labels: pull-request-available
>
> The current BPOfferService.reportBadBlocks() method can be optimized by
> moving the creation of the rbbAction object outside the loop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
