[
https://issues.apache.org/jira/browse/HDFS-17208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769976#comment-17769976
]
ASF GitHub Bot commented on HDFS-17208:
---------------------------------------
haiyang1987 commented on code in PR #6109:
URL: https://github.com/apache/hadoop/pull/6109#discussion_r1339876416
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -3822,5 +3822,10 @@ public long getLastDirScannerFinishTime() {
public void setLastDirScannerFinishTime(long time) {
this.lastDirScannerFinishTime = time;
}
+
+ @Override
+ public long getPendingAsyncDiskOperations() {
Review Comment:
Thanks @Hexiaoqiao for your suggestions.
You are right, the method name definitions at both sides need to be
consistent.
From the current implementation, it might be better to changing
countPendingDeletions to countPendingAsyncDiskOperations, what do you think
about?
> Add the metrics PendingAsyncDiskOperations in datanode
> --------------------------------------------------------
>
> Key: HDFS-17208
> URL: https://issues.apache.org/jira/browse/HDFS-17208
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> Consider should add the metrics `PendingAsyncDiskOperations` to be able to
> track if we are queueing too many asynchronous disk operations in
> FsDatasetAsyncDiskService of the datanode.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
