[ https://issues.apache.org/jira/browse/HDFS-17208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770002#comment-17770002 ]
ASF GitHub Bot commented on HDFS-17208: --------------------------------------- haiyang1987 commented on code in PR #6109: URL: https://github.com/apache/hadoop/pull/6109#discussion_r1339962508 ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ########## @@ -3822,5 +3822,10 @@ public long getLastDirScannerFinishTime() { public void setLastDirScannerFinishTime(long time) { this.lastDirScannerFinishTime = time; } + + @Override + public long getPendingAsyncDiskOperations() { Review Comment: For some test code more about verifying the number of async deletion operations , such as : `FsDatasetTestUtils#getPendingAsyncDeletions` may also need to changes ? > Add the metrics PendingAsyncDiskOperations in datanode > -------------------------------------------------------- > > Key: HDFS-17208 > URL: https://issues.apache.org/jira/browse/HDFS-17208 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Reporter: Haiyang Hu > Assignee: Haiyang Hu > Priority: Major > Labels: pull-request-available > > Consider should add the metrics `PendingAsyncDiskOperations` to be able to > track if we are queueing too many asynchronous disk operations in > FsDatasetAsyncDiskService of the datanode. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org