[ https://issues.apache.org/jira/browse/HDFS-17362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812585#comment-17812585 ]
ASF GitHub Bot commented on HDFS-17362: --------------------------------------- tasanuma commented on code in PR #6510: URL: https://github.com/apache/hadoop/pull/6510#discussion_r1472501788 ########## hadoop-hdfs-project/hadoop-hdfs-rbf/pom.xml: ########## @@ -177,6 +177,11 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd"> <artifactId>junit-jupiter-params</artifactId> <scope>test</scope> </dependency> + <dependency> + <groupId>org.junit.jupiter</groupId> + <artifactId>junit-jupiter-engine</artifactId> + <scope>test</scope> + </dependency> Review Comment: Agreed, I deleted it by 0e66511214db118df601b41670c1446e63f97f49. I will create another ticket. > RBF: RouterObserverReadProxyProvider should use > ConfiguredFailoverProxyProvider internally > ------------------------------------------------------------------------------------------ > > Key: HDFS-17362 > URL: https://issues.apache.org/jira/browse/HDFS-17362 > Project: Hadoop HDFS > Issue Type: Task > Reporter: Takanobu Asanuma > Assignee: Takanobu Asanuma > Priority: Major > Labels: pull-request-available > > Currently, RouterObserverReadProxyProvider is using IPFailoverProxyProvider, > while ObserverReadProxyProvider is using ConfiguredFailoverProxyProvider. If > we are to align RouterObserverReadProxyProvider with > ObserverReadProxyProvider, RouterObserverReadProxyProvider should internally > use ConfiguredFailoverProxyProvider. Moreover, IPFailoverProxyProvider has > an issue with resolving HA configurations. (For example, > IPFailoverProxyProvider cannot resolve hdfs://router-service.) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org