[
https://issues.apache.org/jira/browse/HDFS-17362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813673#comment-17813673
]
ASF GitHub Bot commented on HDFS-17362:
---------------------------------------
tasanuma commented on code in PR #6510:
URL: https://github.com/apache/hadoop/pull/6510#discussion_r1476061151
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/RouterObserverReadProxyProvider.java:
##########
@@ -84,7 +84,8 @@ public class RouterObserverReadProxyProvider<T> extends
AbstractNNFailoverProxyP
public RouterObserverReadProxyProvider(Configuration conf, URI uri, Class<T>
xface,
HAProxyFactory<T> factory) {
- this(conf, uri, xface, factory, new IPFailoverProxyProvider<>(conf, uri,
xface, factory));
+ this(conf, uri, xface, factory,
+ new ConfiguredFailoverProxyProvider<>(conf, uri, xface, factory));
Review Comment:
As an alternative approach, what if we created a
`RouterObserverReadProxyProviderWithIPFailover` using `IPFailoverProxyProvider`
to align it with `ObserverReadProxyProviderWithIPFailover`?
```java
public class RouterObserverReadProxyProviderWithIPFailover<T>
extends RouterObserverReadProxyProvider<T> {
@VisibleForTesting
static final Logger LOG =
LoggerFactory.getLogger(RouterObserverReadProxyProviderWithIPFailover.class);
public RouterObserverReadProxyProviderWithIPFailover(Configuration conf,
URI uri, Class<T> xface,
HAProxyFactory<T> factory) {
super(conf, uri, xface, factory, new IPFailoverProxyProvider<>(conf,
uri, xface, factory));
}
}
```
> RBF: RouterObserverReadProxyProvider should use
> ConfiguredFailoverProxyProvider internally
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-17362
> URL: https://issues.apache.org/jira/browse/HDFS-17362
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Major
> Labels: pull-request-available
>
> Currently, RouterObserverReadProxyProvider is using IPFailoverProxyProvider,
> while ObserverReadProxyProvider is using ConfiguredFailoverProxyProvider. If
> we are to align RouterObserverReadProxyProvider with
> ObserverReadProxyProvider, RouterObserverReadProxyProvider should internally
> use ConfiguredFailoverProxyProvider. Moreover, IPFailoverProxyProvider has
> an issue with resolving HA configurations. (For example,
> IPFailoverProxyProvider cannot resolve hdfs://router-service.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
