[
https://issues.apache.org/jira/browse/HDFS-17352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820944#comment-17820944
]
ASF GitHub Bot commented on HDFS-17352:
---------------------------------------
zhangshuyan0 commented on code in PR #6559:
URL: https://github.com/apache/hadoop/pull/6559#discussion_r1503587650
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml:
##########
@@ -3982,6 +3982,17 @@
</description>
</property>
+<property>
+ <name>dfs.datanode.delete.corrupt.replica.from.disk.enable</name>
+ <value>true</value>
Review Comment:
If the default value is true, there is a risk of block missing according to
[HDFS-16985](https://issues.apache.org/jira/browse/HDFS-16985). I suggest
setting the default value to false, as block missing is a more serious problem
than disk file deletion delay. What's your opion?
> Add configuration to control whether DN delete this replica from disk when
> client requests a missing block
> -----------------------------------------------------------------------------------------------------------
>
> Key: HDFS-17352
> URL: https://issues.apache.org/jira/browse/HDFS-17352
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> As discussed at
> https://github.com/apache/hadoop/pull/6464#issuecomment-1902959898
> we should add configuration to control whether DN delete this replica from
> disk when client requests a missing block.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
