[
https://issues.apache.org/jira/browse/HDFS-17352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821550#comment-17821550
]
ASF GitHub Bot commented on HDFS-17352:
---------------------------------------
haiyang1987 commented on code in PR #6559:
URL: https://github.com/apache/hadoop/pull/6559#discussion_r1505502474
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml:
##########
@@ -3982,6 +3982,17 @@
</description>
</property>
+<property>
+ <name>dfs.datanode.delete.corrupt.replica.from.disk.enable</name>
+ <value>true</value>
Review Comment:
Thanks @zhangshuyan0 for your comment.
From the DataNode point of view, if already confirmed the meta file or data
file is lost. it should be deleted directly from the memory and disk and this
is expected behavior.
For HDFS-16985 mentioned, if the current cluster deployment adopts the AWS
EC2 + EBS solution, can adjust
`dfs.datanode.delete.corrupt.replica.from.disk.enable` is false as needed to
avoid deleting disk data.
So I think it might be better from datanode perspective default to set
`dfs.datanode.delete.corrupt.replica.from.disk.enable` to true
looking forward to your suggestions again.
> Add configuration to control whether DN delete this replica from disk when
> client requests a missing block
> -----------------------------------------------------------------------------------------------------------
>
> Key: HDFS-17352
> URL: https://issues.apache.org/jira/browse/HDFS-17352
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> As discussed at
> https://github.com/apache/hadoop/pull/6464#issuecomment-1902959898
> we should add configuration to control whether DN delete this replica from
> disk when client requests a missing block.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
