[
https://issues.apache.org/jira/browse/HDFS-17402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824972#comment-17824972
]
ASF GitHub Bot commented on HDFS-17402:
---------------------------------------
zhuzilong2013 opened a new pull request, #6618:
URL: https://github.com/apache/hadoop/pull/6618
### Description of PR
Refer to [HDFS-17402](https://issues.apache.org/jira/browse/HDFS-17402).
After [HDFS-17231](https://issues.apache.org/jira/browse/HDFS-17231),
NameNode can exit safemode automatically when resources are from low to
available. It used
org.apache.hadoop.hdfs.server.namenode.FSNamesystem#leaveSafeMode, this
function will change BMSafeModeStatus. However, NameNode entering resource low
safe mode doesn't change BMSafeModeStatus in
org.apache.hadoop.hdfs.server.namenode.FSNamesystem#enterSafeMode. This is not
equal
Now:
a. NN enter StartupSafeMode
b. NN enter ResourceLowSafeMode
c. NN resources from low to available
d. NN safemode off
Expectations：
a. NN enter StartupSafeMode
b. NN enter ResourceLowSafeMode
c. NN resources from low to available
d. NN exit ResourceLowSafeMode but in StartupSafeMode
### How was this patch tested?
Add UT
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> StartupSafeMode should not exit when resources are from low to available
> ------------------------------------------------------------------------
>
> Key: HDFS-17402
> URL: https://issues.apache.org/jira/browse/HDFS-17402
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Zilong Zhu
> Priority: Major
>
> After HDFS-17231, NameNode can exit safemode automatically when resources are
> from low to available. It used
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem#leaveSafeMode, this
> function will change BMSafeModeStatus. However, NameNode entering resource
> low safe mode doesn't change BMSafeModeStatus in
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem#enterSafeMode. This is
> not equal
> Now:
> a. NN enter StartupSafeMode
> b. NN enter ResourceLowSafeMode
> c. NN resources from low to available
> d. NN safemode off
>
> Expectations：
> a. NN enter StartupSafeMode
> b. NN enter ResourceLowSafeMode
> c. NN resources from low to available
> d. NN exit ResourceLowSafeMode but in StartupSafeMode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
