[ 
https://issues.apache.org/jira/browse/HDFS-17402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840599#comment-17840599
 ] 

ASF GitHub Bot commented on HDFS-17402:
---------------------------------------

hadoop-yetus commented on PR #6618:
URL: https://github.com/apache/hadoop/pull/6618#issuecomment-2076062911

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m 00s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  spotbugs  |   0m 01s |  |  spotbugs executables are not 
available.  |
   | +0 :ok: |  codespell  |   0m 01s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m 01s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m 00s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m 00s |  |  The patch appears to 
include 1 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  96m 45s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 36s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   5m 03s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   7m 14s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   6m 33s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  | 155m 32s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 46s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 55s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 55s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m 00s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   2m 28s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   4m 23s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 40s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  | 163m 27s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   5m 39s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 444m 09s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | GITHUB PR | https://github.com/apache/hadoop/pull/6618 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | MINGW64_NT-10.0-17763 e13068a72d28 3.4.10-87d57229.x86_64 
2024-02-14 20:17 UTC x86_64 Msys |
   | Build tool | maven |
   | Personality | /c/hadoop/dev-support/bin/hadoop.sh |
   | git revision | trunk / 21fb4a3fb7d6153f6c54f8486f600e8f6ac97532 |
   | Default Java | Azul Systems, Inc.-1.8.0_332-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6618/1/testReport/
 |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6618/1/console
 |
   | versions | git=2.44.0.windows.1 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> StartupSafeMode should not exit when resources are from low to available
> ------------------------------------------------------------------------
>
>                 Key: HDFS-17402
>                 URL: https://issues.apache.org/jira/browse/HDFS-17402
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Zilong Zhu
>            Priority: Major
>              Labels: pull-request-available
>
> After HDFS-17231, NameNode can exit safemode automatically when resources are 
> from low to available. It used 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem#leaveSafeMode, this 
> function will change BMSafeModeStatus. However, NameNode entering resource 
> low safe mode doesn't change BMSafeModeStatus in 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem#enterSafeMode. This is 
> not equal
> Now:
> a. NN enter StartupSafeMode
> b. NN enter ResourceLowSafeMode
> c. NN resources from low to available
> d. NN safemode off
>  
> Expectations:
> a. NN enter StartupSafeMode
> b. NN enter ResourceLowSafeMode
> c. NN resources from low to available
> d. NN exit ResourceLowSafeMode but in StartupSafeMode



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to