[
https://issues.apache.org/jira/browse/HDFS-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18014357#comment-18014357
]
ASF GitHub Bot commented on HDFS-12431:
---------------------------------------
slfan1989 commented on code in PR #7873:
URL: https://github.com/apache/hadoop/pull/7873#discussion_r2280666386
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDeduplicationMap.java:
##########
@@ -19,18 +19,18 @@
package org.apache.hadoop.hdfs.server.namenode;
import
org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf.SaverContext.DeduplicationMap;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
public class TestDeduplicationMap {
@Test
public void testDeduplicationMap() {
DeduplicationMap<String> m = DeduplicationMap.newMap();
- Assert.assertEquals(1, m.getId("1"));
- Assert.assertEquals(2, m.getId("2"));
- Assert.assertEquals(3, m.getId("3"));
- Assert.assertEquals(1, m.getId("1"));
- Assert.assertEquals(2, m.getId("2"));
- Assert.assertEquals(3, m.getId("3"));
+ Assertions.assertEquals(1, m.getId("1"));
Review Comment:
just like the above.
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs
> -----------------------------------------------
>
> Key: HDFS-12431
> URL: https://issues.apache.org/jira/browse/HDFS-12431
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Ajay Kumar
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs (i.e org.apache.hadoop.hdfs)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
