[
https://issues.apache.org/jira/browse/HDFS-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015410#comment-18015410
]
ASF GitHub Bot commented on HDFS-12431:
---------------------------------------
leosanqing commented on code in PR #7890:
URL: https://github.com/apache/hadoop/pull/7890#discussion_r2290718044
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/FSImageTestUtil.java:
##########
@@ -445,8 +445,8 @@ public static void assertFileContentsDifferent(
public static Map<File, String> getFileMD5s(File... files) throws Exception {
Map<File, String> ret = Maps.newHashMap();
for (File f : files) {
- assertTrue("Must exist: " + f, f.exists());
- ret.put(f, getFileMD5(f));
+ assertTrue(f.exists(), "Must exist: " + f);
Review Comment:
Hi, it looks like there might be an extra indent here.
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs
> -----------------------------------------------
>
> Key: HDFS-12431
> URL: https://issues.apache.org/jira/browse/HDFS-12431
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Ajay Kumar
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs (i.e org.apache.hadoop.hdfs)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
