[ https://issues.apache.org/jira/browse/HDFS-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210998#comment-13210998 ]
Hadoop QA commented on HDFS-2966: --------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515090/HDFS-2966.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1885//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1885//console This message is automatically generated. > TestNameNodeMetrics tests can fail under load > --------------------------------------------- > > Key: HDFS-2966 > URL: https://issues.apache.org/jira/browse/HDFS-2966 > Project: Hadoop HDFS > Issue Type: Bug > Components: test > Affects Versions: 0.24.0 > Environment: OS/X running intellij IDEA, firefox, winxp in a > virtualbox. > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Minor > Attachments: HDFS-2966.patch > > > I've managed to recreate HDFS-540 and HDFS-2434 by the simple technique of > running the HDFS tests on a desktop with out enough memory for all the > programs trying to run. Things got swapped out and the tests failed as the DN > heartbeats didn't come in on time. > the tests both rely on {{waitForDeletion()}} to block the tests until the > delete operation has completed, but all it does is sleep for the same number > of seconds as there are datanodes. This is too brittle -it may work on a > lightly-loaded system, but not on a system under heavy load where it is > taking longer to replicate than expect. > Immediate fix: double, triple, the sleep time? > Better fix: have the thread block until all the DN heartbeats have finished. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira