[
https://issues.apache.org/jira/browse/HDFS-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216230#comment-13216230
]
Aaron T. Myers commented on HDFS-2966:
--------------------------------------
bq. Rather than rename the method, I made the metric scope a parameter, so it
can block for other metrics too.
I still find the name a tad misleading, since the method is still a little
DN-specific. e.g. it retries based on the number of DNs, and sleeps a multiple
of DFS_REPLICATION_INTERVAL. But, I don't feel super strongly about this point.
Take it or leave it.
+1, the patch looks good to me, assuming you don't want to address the above
feedback.
> TestNameNodeMetrics tests can fail under load
> ---------------------------------------------
>
> Key: HDFS-2966
> URL: https://issues.apache.org/jira/browse/HDFS-2966
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.24.0
> Environment: OS/X running intellij IDEA, firefox, winxp in a
> virtualbox.
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HDFS-2966.patch, HDFS-2966.patch, HDFS-2966.patch
>
>
> I've managed to recreate HDFS-540 and HDFS-2434 by the simple technique of
> running the HDFS tests on a desktop with out enough memory for all the
> programs trying to run. Things got swapped out and the tests failed as the DN
> heartbeats didn't come in on time.
> the tests both rely on {{waitForDeletion()}} to block the tests until the
> delete operation has completed, but all it does is sleep for the same number
> of seconds as there are datanodes. This is too brittle -it may work on a
> lightly-loaded system, but not on a system under heavy load where it is
> taking longer to replicate than expect.
> Immediate fix: double, triple, the sleep time?
> Better fix: have the thread block until all the DN heartbeats have finished.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
