[
https://issues.apache.org/jira/browse/HDFS-17943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18096094#comment-18096094
]
ASF GitHub Bot commented on HDFS-17943:
---------------------------------------
namest504 opened a new pull request, #8602:
URL: https://github.com/apache/hadoop/pull/8602
### Description of PR
This PR fixes [HDFS-17943](https://issues.apache.org/jira/browse/HDFS-17943).
When `dfs.domain.socket.disable.interval.seconds` is set to a negative
value, the client fails with a malformed error message — a space is missing
between the configuration key and the rest of the message:
```
java.lang.IllegalArgumentException:
dfs.domain.socket.disable.interval.secondscan't be negative.
```
This change adds the missing space in the `Preconditions.checkArgument`
message in `DfsClientConf.ShortCircuitConf`, so the message now reads:
```
dfs.domain.socket.disable.interval.seconds can't be negative.
```
### How was this patch tested?
Added
`TestDfsClientConf#testNegativeDomainSocketDisableIntervalErrorMessage`, which
sets the config to `-1` and asserts that constructing `DfsClientConf` throws
`IllegalArgumentException` with the corrected message. The test fails on trunk
(reproducing the malformed message) and passes with this change:
```
mvn -pl hadoop-hdfs-project/hadoop-hdfs-client test -Dtest=TestDfsClientConf
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
```
`checkstyle` reports no new violations for the touched files.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
Contains content generated by Claude Code.
- [x] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> Negative dfs.domain.socket.disable.interval.seconds reports malformed error
> message
> -----------------------------------------------------------------------------------
>
> Key: HDFS-17943
> URL: https://issues.apache.org/jira/browse/HDFS-17943
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: configuration, hdfs-client
> Affects Versions: 3.4.3
> Reporter: jiang he
> Priority: Trivial
>
> I found a malformed error message when setting
> dfs.domain.socket.disable.interval.seconds to a negative value.
> Reproduction:
> Set the following HDFS configuration:
> <property>
> <name>dfs.domain.socket.disable.interval.seconds</name>
> <value>-1</value>
> </property>
> or:
> <property>
> <name>dfs.domain.socket.disable.interval.seconds</name>
> <value>-4294967296</value>
> </property>
> Then start HDFS and run a simple HDFS client operation with short-circuit
> read enabled.
> Actual result:
> The client fails with:
> java.lang.IllegalArgumentException:
> dfs.domain.socket.disable.interval.secondscan't be negative.
> The message is malformed: "secondscan't" is missing a space.
> Expected result:
> The error message should be readable, for example:
> dfs.domain.socket.disable.interval.seconds can't be negative.
> Reproduced locally:
> - Negative value case failed.
> - Normal value dfs.domain.socket.disable.interval.seconds=600 passed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
