[
https://issues.apache.org/jira/browse/HDFS-17943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18096897#comment-18096897
]
ASF GitHub Bot commented on HDFS-17943:
---------------------------------------
ayushtkn commented on code in PR #8603:
URL: https://github.com/apache/hadoop/pull/8603#discussion_r3598779194
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/DfsClientConf.java:
##########
@@ -866,7 +866,8 @@ public ShortCircuitConf(Configuration conf) {
DFS_DOMAIN_SOCKET_DISABLE_INTERVAL_SECOND_KEY,
DFS_DOMAIN_SOCKET_DISABLE_INTERVAL_SECOND_DEFAULT);
Preconditions.checkArgument(domainSocketDisableIntervalSeconds >= 0,
- DFS_DOMAIN_SOCKET_DISABLE_INTERVAL_SECOND_KEY + "can't be
negative.");
+ DFS_DOMAIN_SOCKET_DISABLE_INTERVAL_SECOND_KEY
+ + " can't be negative.");
Review Comment:
i think the line length supported is 120, we don't need a line break here
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/client/impl/TestDfsClientConf.java:
##########
@@ -0,0 +1,41 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdfs.client.impl;
Review Comment:
we can live without a test for this case, no need to add a test file for
this :-)
> Negative dfs.domain.socket.disable.interval.seconds reports malformed error
> message
> -----------------------------------------------------------------------------------
>
> Key: HDFS-17943
> URL: https://issues.apache.org/jira/browse/HDFS-17943
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: configuration, hdfs-client
> Affects Versions: 3.4.3
> Reporter: jiang he
> Priority: Trivial
> Labels: pull-request-available
>
> I found a malformed error message when setting
> dfs.domain.socket.disable.interval.seconds to a negative value.
> Reproduction:
> Set the following HDFS configuration:
> <property>
> <name>dfs.domain.socket.disable.interval.seconds</name>
> <value>-1</value>
> </property>
> or:
> <property>
> <name>dfs.domain.socket.disable.interval.seconds</name>
> <value>-4294967296</value>
> </property>
> Then start HDFS and run a simple HDFS client operation with short-circuit
> read enabled.
> Actual result:
> The client fails with:
> java.lang.IllegalArgumentException:
> dfs.domain.socket.disable.interval.secondscan't be negative.
> The message is malformed: "secondscan't" is missing a space.
> Expected result:
> The error message should be readable, for example:
> dfs.domain.socket.disable.interval.seconds can't be negative.
> Reproduced locally:
> - Negative value case failed.
> - Normal value dfs.domain.socket.disable.interval.seconds=600 passed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
