[
https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225331#comment-13225331
]
Colin Patrick McCabe commented on HDFS-3050:
--------------------------------------------
Hi Nicholas,
I implemented solution #4 from the ones we talked about.
I definitely agree with you that in the long term, it may make more sense to
use the visitor pattern to deal with these FSEditLogOp classes. (This is
solution #2.) However, that's a bigger change and probably something we should
plan out later.
Anyway, as always, thanks for taking the time to look at this.
cheers,
C.
> refactor OEV to share more code with the NameNode
> -------------------------------------------------
>
> Key: HDFS-3050
> URL: https://issues.apache.org/jira/browse/HDFS-3050
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3050.004.patch
>
>
> Current, OEV (the offline edits viewer) re-implements all of the opcode
> parsing logic found in the NameNode. This duplicated code creates a
> maintenance burden for us.
> OEV should be refactored to simply use the normal EditLog parsing code,
> rather than rolling its own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
