[
https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226624#comment-13226624
]
Eli Collins commented on HDFS-3050:
-----------------------------------
Hey Colin,
Agree that #4 is good approach, can punt on #2 for now.
Overall your patch looks great, minor stuff:
- PermissionStatus, DelegationKey, Block, DelegationTokenIdentifier diffs are
just unused imports
- addSaxString and OfflineEditsViewer#go could use a small javadoc each
- Brackets go on the same line as clauses (can update your editor to do this,
start with the Java conventions and update to no tabs and two space indent)
Thanks,
Eli
> refactor OEV to share more code with the NameNode
> -------------------------------------------------
>
> Key: HDFS-3050
> URL: https://issues.apache.org/jira/browse/HDFS-3050
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3050.004.patch
>
>
> Current, OEV (the offline edits viewer) re-implements all of the opcode
> parsing logic found in the NameNode. This duplicated code creates a
> maintenance burden for us.
> OEV should be refactored to simply use the normal EditLog parsing code,
> rather than rolling its own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
