[
https://issues.apache.org/jira/browse/HDFS-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408491#comment-13408491
]
Eli Collins commented on HDFS-711:
----------------------------------
What systems have an unsigned time_t? Thought Unix std was signed.
IMO using -1 makes sense because it (1) matches the HDFS API and (2) allows you
to set zero values which this patch doesn't allow because it overloads zero
right?
> hdfsUtime does not handle atime = 0 or mtime = 0 correctly
> ----------------------------------------------------------
>
> Key: HDFS-711
> URL: https://issues.apache.org/jira/browse/HDFS-711
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
> Affects Versions: 0.20.1
> Reporter: freestyler
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-711.001.patch
>
>
> in HADOOP/src/c++/libhdfs/hdfs.h
> The following function document is incorrect:
> /* @param mtime new modification time or 0 for only set access time in
> seconds
> @param atime new access time or 0 for only set modification time in
> seconds
> */
> int hdfsUtime(hdfsFS fs, const char* path, tTime mtime, tTime atime);
> Currently, setting mtime or atime to 0 has no special meaning. That is, file
> last modified time will change to 0 if the mtime argument is 0.
> libhdfs should translate mtime = 0 or atime = 0 to the special value -1,
> which in HDFS means "don't change this time."
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
