[
https://issues.apache.org/jira/browse/HDFS-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408495#comment-13408495
]
Hadoop QA commented on HDFS-711:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12535400/HDFS-711.001.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDatanodeBlockScanner
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/2752//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/2752//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2752//console
This message is automatically generated.
> hdfsUtime does not handle atime = 0 or mtime = 0 correctly
> ----------------------------------------------------------
>
> Key: HDFS-711
> URL: https://issues.apache.org/jira/browse/HDFS-711
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
> Affects Versions: 0.20.1
> Reporter: freestyler
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-711.001.patch
>
>
> in HADOOP/src/c++/libhdfs/hdfs.h
> The following function document is incorrect:
> /* @param mtime new modification time or 0 for only set access time in
> seconds
> @param atime new access time or 0 for only set modification time in
> seconds
> */
> int hdfsUtime(hdfsFS fs, const char* path, tTime mtime, tTime atime);
> Currently, setting mtime or atime to 0 has no special meaning. That is, file
> last modified time will change to 0 if the mtime argument is 0.
> libhdfs should translate mtime = 0 or atime = 0 to the special value -1,
> which in HDFS means "don't change this time."
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
