[ https://issues.apache.org/jira/browse/HDFS-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409622#comment-13409622 ]
Eli Collins commented on HDFS-3606: ----------------------------------- Looks good, minor comments - This function doesn't actually write/read a file. Also I'd pull the code out to something like testWriteFile {code} /** * Test that we can write a file with libhdfs and then read it back */ int main(void) { {code} - Style nit: remove extern from the function prototypes in nativeMiniDfs.h > libhdfs: create self-contained unit test > ---------------------------------------- > > Key: HDFS-3606 > URL: https://issues.apache.org/jira/browse/HDFS-3606 > Project: Hadoop HDFS > Issue Type: Test > Components: libhdfs > Affects Versions: 2.0.1-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HDFS-3606.001.patch > > > We should have a self-contained unit test for libhdfs and also for FUSE. > We do have hdfs_test, but it is not self-contained (it requires a cluster to > already be running before it can be used.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira