[
https://issues.apache.org/jira/browse/HDFS-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin Patrick McCabe updated HDFS-3606:
---------------------------------------
Attachment: HDFS-3606.004.patch
You're absolutely right about the references-- after the
MiniDFSCluster#Builder methods that return a reference to the Builder, we will
have to free that reference.
I made the other changes you suggested.
expect.h is just a few macros to make things shorter in the libhdfs unit test.
It's not really a framework per se. It's very specific to libhdfs because it
does things like print out errno (we have that error convention in libhdfs,
etc.)
I changed the native_mini_dfs methods to return negative error codes. It just
makes more sense since nmdGetNameNodePort returns a positive port number on
success. In general I try to return negative codes unless someone has already
established the opposite convention, and I don't want to change it too much.
> libhdfs: create self-contained unit test
> ----------------------------------------
>
> Key: HDFS-3606
> URL: https://issues.apache.org/jira/browse/HDFS-3606
> Project: Hadoop HDFS
> Issue Type: Test
> Components: libhdfs
> Affects Versions: 2.0.1-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3606.001.patch, HDFS-3606.003.patch,
> HDFS-3606.004.patch
>
>
> We should have a self-contained unit test for libhdfs and also for FUSE.
> We do have hdfs_test, but it is not self-contained (it requires a cluster to
> already be running before it can be used.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
