[ 
https://issues.apache.org/jira/browse/HDFS-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419388#comment-13419388
 ] 

Daryn Sharp commented on HDFS-3680:
-----------------------------------

Todd: good points as well about log ordering and whether the impl should 
enforcing queueing, if so, bounded/unbounded queueing.  I'm not sure there's a 
one-size-fits-all, and flexibility could become very complex.  I'm a bit 
squeamish of no queueing and leaving it up to the user since the logging is 
inside the namesystem lock.  It'll be all too easy to add latency or even stall 
the NN entirely trying to log a write op.

While conceptually this jira is good idea, this is in a very critical portion 
of the NN that risks dire performance impacts. I'm inclined to think/propose 
other audit loggers should post-process the audit file in a separate process.



                
> Allows customized audit logging in HDFS FSNamesystem
> ----------------------------------------------------
>
>                 Key: HDFS-3680
>                 URL: https://issues.apache.org/jira/browse/HDFS-3680
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Marcelo Vanzin
>            Assignee: Marcelo Vanzin
>            Priority: Minor
>         Attachments: accesslogger-v1.patch, accesslogger-v2.patch
>
>
> Currently, FSNamesystem writes audit logs to a logger; that makes it easy to 
> get audit logs in some log file. But it makes it kinda tricky to store audit 
> logs in any other way (let's say a database), because it would require the 
> code to implement a log appender (and thus know what logging system is 
> actually being used underneath the façade), and parse the textual log message 
> generated by FSNamesystem.
> I'm attaching a patch that introduces a cleaner interface for this use case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to