[
https://issues.apache.org/jira/browse/HDFS-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425356#comment-13425356
]
Suresh Srinivas commented on HDFS-3680:
---------------------------------------
bq. That poses an issue, though. Would there be resistance to make those two
classes public?
The only issue is, we are now limiting our ability to change these classes. I
think for now, we should keep the AuditLogger it self as non Pulic. Any one
implementing it understands that these interfaces are currently not public.
bq. Are you OK with catching RuntimeException?
Now I see the issue. I think catching Exception in that case is case. Adding a
comment to describe the reason would be great. Also we should handle a problem
where a logger is not functional/degraded and causes exceptions all the time.
bq. Any particular reason why?
The test is for AuditLogger functionality and not FSNamesystem. The detail that
logger list is handled and used in FSNamesystem is an implementation detail.
bq. ... FSNamesystem trying to call the (now private) constructor would cause
an IllegalAccessException.
Makes sense.
> Allows customized audit logging in HDFS FSNamesystem
> ----------------------------------------------------
>
> Key: HDFS-3680
> URL: https://issues.apache.org/jira/browse/HDFS-3680
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Marcelo Vanzin
> Assignee: Marcelo Vanzin
> Priority: Minor
> Attachments: accesslogger-v1.patch, accesslogger-v2.patch,
> hdfs-3680-v3.patch, hdfs-3680-v4.patch
>
>
> Currently, FSNamesystem writes audit logs to a logger; that makes it easy to
> get audit logs in some log file. But it makes it kinda tricky to store audit
> logs in any other way (let's say a database), because it would require the
> code to implement a log appender (and thus know what logging system is
> actually being used underneath the façade), and parse the textual log message
> generated by FSNamesystem.
> I'm attaching a patch that introduces a cleaner interface for this use case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
