[ 
https://issues.apache.org/jira/browse/HDFS-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424063#comment-13424063
 ] 

Daryn Sharp commented on HDFS-3513:
-----------------------------------

Fair enough, 
# It looks like there's a synchronization issue in {{closeFileSystem}} that can 
cause an NPE if the fs is purged by another thread between the contains and 
get?  
# The cache handling in {{createFileSystem}} looks error prone.  It's taking a 
conf, but ignoring when looking up a cache entry, then duping it before getting 
the fs which again is going to ignore the conf if fs is already set?
# Not a big deal, but I'd suggest commonizing {{release}} and {{purgeIfIdle}} 
for the former to call the latter to avoid copy-n-paste code.  Just a 
suggestion.

                
> HttpFS should cache filesystems
> -------------------------------
>
>                 Key: HDFS-3513
>                 URL: https://issues.apache.org/jira/browse/HDFS-3513
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: HDFS-3513.patch, HDFS-3513.patch, HDFS-3513.patch, 
> HDFS-3513.patch
>
>
> HttpFS opens and closes a FileSystem instance against the backend filesystem 
> (typically HDFS) on every request. The FileSystem caching is not used as it 
> does not have expiration/timeout and filesystem instances in there live 
> forever, for long running services like HttpFS this is not a good thing as it 
> would keep connections open to the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to