[ 
https://issues.apache.org/jira/browse/HDFS-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424997#comment-13424997
 ] 

Alejandro Abdelnur commented on HDFS-3513:
------------------------------------------

Daryn, thxs for reviewing the patch.

#1 as explained in the comment in the purgeIfIdle() method, entries from the 
cache are never removed, only the FileSystem instance is closed.

#2 the cache is exclusively on per user, not on configuration. As all 
configurations are created in the same way, for a given user they are 
identical. The duping is only done because we are injecting a property and the 
passed configuration is not owned by the createFileSystem method.

#3 I've given it a try by it complicates the purgeIfIdle logic, I'd prefer to 
leave it like it is.
                
> HttpFS should cache filesystems
> -------------------------------
>
>                 Key: HDFS-3513
>                 URL: https://issues.apache.org/jira/browse/HDFS-3513
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: HDFS-3513.patch, HDFS-3513.patch, HDFS-3513.patch, 
> HDFS-3513.patch
>
>
> HttpFS opens and closes a FileSystem instance against the backend filesystem 
> (typically HDFS) on every request. The FileSystem caching is not used as it 
> does not have expiration/timeout and filesystem instances in there live 
> forever, for long running services like HttpFS this is not a good thing as it 
> would keep connections open to the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to