[
https://issues.apache.org/jira/browse/HDFS-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426616#comment-13426616
]
Ivan Kelly commented on HDFS-3695:
----------------------------------
Generally looks good to me.
One issue though, it that there is now way to confirm with the user that they
do in fact want to clear the journal. Perhaps you could define a confirmation
callback which could be passed down through.
{code}
interface FormatConfirmationCallback {
boolean confirmFormat(URI journal);
}
{code}
Are you planning on putting this in trunk and branch-2 at the same time as
HDFS-3077 branch?
> Genericize format() and initializeSharedEdits() to non-file JournalManagers
> ---------------------------------------------------------------------------
>
> Key: HDFS-3695
> URL: https://issues.apache.org/jira/browse/HDFS-3695
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: QuorumJournalManager (HDFS-3077)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-3695.txt
>
>
> Currently, the "namenode -format" and "namenode -initializeSharedEdits"
> commands do not understand how to do anything with non-file-based shared
> storage. This affects both BookKeeperJournalManager and QuorumJournalManager.
> This JIRA is to plumb through the formatting of edits directories using
> pluggable journal manager implementations so that no separate step needs to
> be taken to format them -- the same commands will work for NFS-based storage
> or one of the alternate implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
