[ https://issues.apache.org/jira/browse/HDFS-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447512#comment-13447512 ]
Hadoop QA commented on HDFS-3887: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543596/HDFS-3887.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3139//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3139//console This message is automatically generated. > Remove redundant chooseTarget methods in BlockPlacementPolicy.java > ------------------------------------------------------------------ > > Key: HDFS-3887 > URL: https://issues.apache.org/jira/browse/HDFS-3887 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 3.0.0 > Reporter: Jing Zhao > Assignee: Jing Zhao > Priority: Trivial > Attachments: HDFS-3887.patch > > > BlockPlacementPolicy.java contains multiple chooseTarget() methods with > different parameter lists. It is difficult to follow and understand the code > since some chooseTarget methods only have minor differences and some of them > are only invoked by testing code. > In this patch, I try to remove some of the chooseTarget methods and only keep > three of them: two abstract methods and the third one using BlockCollection > as its parameter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira