[
https://issues.apache.org/jira/browse/HDFS-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448687#comment-13448687
]
Hudson commented on HDFS-3887:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1156 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1156/])
HDFS-3887. Remove redundant chooseTarget methods in BlockPlacementPolicy.
Contributed by Jing Zhao (Revision 1380934)
Result = SUCCESS
szetszwo :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380934
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicy.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicy.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicyWithNodeGroup.java
> Remove redundant chooseTarget methods in BlockPlacementPolicy.java
> ------------------------------------------------------------------
>
> Key: HDFS-3887
> URL: https://issues.apache.org/jira/browse/HDFS-3887
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 3.0.0
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Priority: Trivial
> Fix For: 2.2.0-alpha
>
> Attachments: HDFS-3887.patch
>
>
> BlockPlacementPolicy.java contains multiple chooseTarget() methods with
> different parameter lists. It is difficult to follow and understand the code
> since some chooseTarget methods only have minor differences and some of them
> are only invoked by testing code.
> In this patch, I try to remove some of the chooseTarget methods and only keep
> three of them: two abstract methods and the third one using BlockCollection
> as its parameter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
