[ 
https://issues.apache.org/jira/browse/HDFS-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458016#comment-13458016
 ] 

John George commented on HDFS-3373:
-----------------------------------

{quote}
-* If SocketCache is already initialized (i.e. isInitedOnce == true), then the 
parameters c and e will be igored silently.  Would it be a problem?
{quote}

I suppose you actually meant if we should LOG a message in cases where someone 
tries to change the value after it has been set once? I agree that it is a good 
idea. 
                
> FileContext HDFS implementation can leak socket caches
> ------------------------------------------------------
>
>                 Key: HDFS-3373
>                 URL: https://issues.apache.org/jira/browse/HDFS-3373
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Todd Lipcon
>            Assignee: John George
>         Attachments: HDFS-3373.branch-23.patch, HDFS-3373.trunk.patch, 
> HDFS-3373.trunk.patch.1
>
>
> As noted by Nicholas in HDFS-3359, FileContext doesn't have a close() method, 
> and thus never calls DFSClient.close(). This means that, until finalizers 
> run, DFSClient will hold on to its SocketCache object and potentially have a 
> lot of outstanding sockets/fds held on to.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to