[
https://issues.apache.org/jira/browse/HDFS-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462787#comment-13462787
]
Tsz Wo (Nicholas), SZE commented on HDFS-3373:
----------------------------------------------
{code}
+ private synchronized void evictExpired(long expiryPeriod)
+ throws IOException {
{code}
evictExpired(..) still has "throws IOException" but IOException is never
thrown in the code. Patch looks good other than that.
> FileContext HDFS implementation can leak socket caches
> ------------------------------------------------------
>
> Key: HDFS-3373
> URL: https://issues.apache.org/jira/browse/HDFS-3373
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Todd Lipcon
> Assignee: John George
> Attachments: HDFS-3373.branch-23.patch, HDFS-3373.trunk.patch,
> HDFS-3373.trunk.patch.1, HDFS-3373.trunk.patch.2, HDFS-3373.trunk.patch.3,
> HDFS-3373.trunk.patch.3
>
>
> As noted by Nicholas in HDFS-3359, FileContext doesn't have a close() method,
> and thus never calls DFSClient.close(). This means that, until finalizers
> run, DFSClient will hold on to its SocketCache object and potentially have a
> lot of outstanding sockets/fds held on to.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
