[ 
https://issues.apache.org/jira/browse/HDFS-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473527#comment-13473527
 ] 

Uma Maheswara Rao G commented on HDFS-4022:
-------------------------------------------

Hi Vinay,

Comments as follows.
{code}
NumberReplicas replicas = countNodes(ucBlock);
+    neededReplications.remove(ucBlock, replicas.liveReplicas(),
+        replicas.decommissionedReplicas(), getReplication(ucBlock));
{code}

We may have to decrement replication index right? and keep them in 
neededReplications lock.
Also you have to take care, that whether the block is really in 
neededReplications list and it removed now, then only you may have to decrement 
the index. Could you please check this point? 

Please add timeout for test case.



                
> Replication not happening for appended block
> --------------------------------------------
>
>                 Key: HDFS-4022
>                 URL: https://issues.apache.org/jira/browse/HDFS-4022
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: suja s
>            Assignee: Uma Maheswara Rao G
>            Priority: Blocker
>         Attachments: HDFS-4022.patch
>
>
> Block written and finalized
> Later append called. Block GenTS got changed.
> DN side log 
> "Can't send invalid block 
> BP-407900822-192.xx.xx.xx-1348830837061:blk_-9185630731157263852_108738" 
> logged continously
> NN side log
> "INFO org.apache.hadoop.hdfs.server.namenode.NameNode: Error report from 
> DatanodeRegistration(192.xx.xx.xx, 
> storageID=DS-2040532042-192.xx.xx.xx-50010-1348830863443, infoPort=50075, 
> ipcPort=50020, storageInfo=lv=-40;cid=123456;nsid=116596173;c=0): Can't send 
> invalid block 
> BP-407900822-192.xx.xx.xx-1348830837061:blk_-9185630731157263852_108738" also 
> logged continuosly.
> The block checked for tansfer is the one with old genTS whereas the new block 
> with updated genTS exist in the data dir.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to