[ 
https://issues.apache.org/jira/browse/HDFS-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477553#comment-13477553
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4022:
----------------------------------------------

Hi Vinay, thanks for working on this.  Some comments on the patch:

- PendingReplicationBlocks.remove(Block) actually only decrements 
numReplicasInProgress but not removes it.  So I suggest:
-* rename remove(Block) to decrement(Block) and
-* add a new method for remove.

- Need to acquire the namesystem lock before changing replication.

- Let's remove the "if" and call pendingReplications.remove(ucBlock) anyway.
                
> Replication not happening for appended block
> --------------------------------------------
>
>                 Key: HDFS-4022
>                 URL: https://issues.apache.org/jira/browse/HDFS-4022
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: suja s
>            Assignee: Uma Maheswara Rao G
>            Priority: Blocker
>         Attachments: HDFS-4022.patch, HDFS-4022.patch, HDFS-4022.patch
>
>
> Block written and finalized
> Later append called. Block GenTS got changed.
> DN side log 
> "Can't send invalid block 
> BP-407900822-192.xx.xx.xx-1348830837061:blk_-9185630731157263852_108738" 
> logged continously
> NN side log
> "INFO org.apache.hadoop.hdfs.server.namenode.NameNode: Error report from 
> DatanodeRegistration(192.xx.xx.xx, 
> storageID=DS-2040532042-192.xx.xx.xx-50010-1348830863443, infoPort=50075, 
> ipcPort=50020, storageInfo=lv=-40;cid=123456;nsid=116596173;c=0): Can't send 
> invalid block 
> BP-407900822-192.xx.xx.xx-1348830837061:blk_-9185630731157263852_108738" also 
> logged continuosly.
> The block checked for tansfer is the one with old genTS whereas the new block 
> with updated genTS exist in the data dir.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to