[ 
https://issues.apache.org/jira/browse/HDFS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545772#comment-13545772
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4244:
----------------------------------------------

- update SafeModeException message for FSNamesystem.deleteSnapshot

- use getMutableINodesInPath for SnapshotManager.deleteSnapshot.

- why removing checkPathLength(..) in NameNodeRpcServer.createSnapshot?

- combine SnapshotManager.deleteDiffsForSnapshot(..) to 
INodeDirectorySnapshottable.removeSnapshot(..).  Note that 
INodeDirectorySnapshottable is extending INodeDirectoryWithSnapshot.

In the meantime, let me change TestINodeDirectoryWithSnapshot to test 
deleteSnapshotDiff.

                
> Support deleting snapshots
> --------------------------
>
>                 Key: HDFS-4244
>                 URL: https://issues.apache.org/jira/browse/HDFS-4244
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4244.001.patch, HDFS-4244.002.patch, 
> HDFS-4244.003.patch, HDFS-4244.004.patch, HDFS-4244.005.patch
>
>
> Provide functionality to delete a snapshot, given the name of the snapshot 
> and the path to the directory where the snapshot was taken.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to