[ 
https://issues.apache.org/jira/browse/HDFS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546752#comment-13546752
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4244:
----------------------------------------------

- Deleting snapshot file may lead to block deletion so that 
removeSelfFromCircle() is not enough.  It should use 
collectSubtreeBlocksAndClear(..).

- It no longer needs to add public to INodesInPath.isSnapshot().

- Both createSnapshot and deleteSnapshot has parameters snapshotName and then 
path, but renameSnapshot has path and then the old and the new names.  How 
about changing createSnapshot and deleteSnapshot to have path and then 
snapshotName?

                
> Support deleting snapshots
> --------------------------
>
>                 Key: HDFS-4244
>                 URL: https://issues.apache.org/jira/browse/HDFS-4244
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4244.001.patch, HDFS-4244.002.patch, 
> HDFS-4244.003.patch, HDFS-4244.004.patch, HDFS-4244.005.patch, 
> HDFS-4244.006.patch
>
>
> Provide functionality to delete a snapshot, given the name of the snapshot 
> and the path to the directory where the snapshot was taken.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to