[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547568#comment-13547568
]
Todd Lipcon commented on HDFS-4352:
-----------------------------------
I disagree that this "isn't a good idea". Functions with 10+ unnamed parameters
are bad style in my book (and in other books, like "Effective Java", eg
http://www.informit.com/articles/article.aspx?p=1216151&seqNum=2)
Do you have a better solution to reduce the number of parameters here? I've
looked at this code for many years and always find it gives me a headache
trying to match up the parameter list against the signature, whereas Colin's
patch makes it obvious which parameter is what.
> Encapsulate arguments to BlockReaderFactory in a class
> ------------------------------------------------------
>
> Key: HDFS-4352
> URL: https://issues.apache.org/jira/browse/HDFS-4352
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: 2.0.3-alpha
> Reporter: Colin Patrick McCabe
> Attachments: 01b.patch, 01.patch
>
>
> Encapsulate the arguments to BlockReaderFactory in a class to avoid having to
> pass around 10+ arguments to a few different functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
