[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547578#comment-13547578
]
Todd Lipcon commented on HDFS-4352:
-----------------------------------
Yes, newBlockReader is essentially a wrapper for constructors (aka a "static
factory method").
If you think we should instead have a Builder class, and a {{build}} method
which returns BlockReader, then we'd be following the pattern more closely. I'd
be fine with that as well - only a small difference from what Colin proposed
here. Either is a lot better than the 8 or 12-argument methods we've got.
> Encapsulate arguments to BlockReaderFactory in a class
> ------------------------------------------------------
>
> Key: HDFS-4352
> URL: https://issues.apache.org/jira/browse/HDFS-4352
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: 2.0.3-alpha
> Reporter: Colin Patrick McCabe
> Attachments: 01b.patch, 01.patch
>
>
> Encapsulate the arguments to BlockReaderFactory in a class to avoid having to
> pass around 10+ arguments to a few different functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
