[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547756#comment-13547756
]
Suresh Srinivas commented on HDFS-4352:
---------------------------------------
BTW, just a quick glance at the code, the newBLockReader() is called only 7
times in the code. The new code essentially moves one for one (from a cursory
glance), values previously passed as params directly to the method into the new
Params class. So I am not sure what the advantage of this to the current code
is. If we expect this param list to grow (like MiniDFSCluster) and we keep
adding new variants of newBlockReader() then perhaps this change makes sense.
I am also not sure why one would proliferate Params class to RemoteBlockReader
classes. Given the RemoteBlockReader*#newBlockReader is called only from the
factory, the factory should call only variant of
RemoteBlockReader*#newBlockReader with appropriate set of of parameters. If
these comments apply to HDFS-4353, similar changes perhaps should be made there
as well.
> Encapsulate arguments to BlockReaderFactory in a class
> ------------------------------------------------------
>
> Key: HDFS-4352
> URL: https://issues.apache.org/jira/browse/HDFS-4352
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: 2.0.3-alpha
> Reporter: Colin Patrick McCabe
> Attachments: 01b.patch, 01.patch
>
>
> Encapsulate the arguments to BlockReaderFactory in a class to avoid having to
> pass around 10+ arguments to a few different functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
