[ 
https://issues.apache.org/jira/browse/HDFS-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750939#comment-13750939
 ] 

Binglin Chang commented on HDFS-5066:
-------------------------------------

bq. Is it possible to remove the buildNodeSet method and the nodeset map, since 
inode Id, class name, and localName can all be identified from a given inode?

I am afraid INodeId, className and localName can't provide uniqueness, many 
WithName can have same localName, I guess if we treat different class type with 
different encoding(WithCount_inodeid, WithName_inodeid_snapshotid, 
DstRef_inodeid), uniqueness is possible, but it looks a little strange.



                
> Inode tree with snapshot information visualization 
> ---------------------------------------------------
>
>                 Key: HDFS-5066
>                 URL: https://issues.apache.org/jira/browse/HDFS-5066
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Minor
>         Attachments: HDFS-5066.v1.patch, visnap.png
>
>
> It would be nice to be able to visualize snapshot information, in order to 
> ease the understanding of related data structures. We can generate graph from 
> in memory inode links.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to