[ 
https://issues.apache.org/jira/browse/HDFS-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750965#comment-13750965
 ] 

Jing Zhao commented on HDFS-5066:
---------------------------------

bq. I am afraid INodeId, className and localName can't provide uniqueness

I guess here you mean we need some unique id for all the INodes so that we can 
check whether we have visited them while traversing the graph? Maybe 
INode#getObjectString is what you're looking for?

Another comment is that we may need to define some upper limit for the maximum 
depth and/or maximum number of inodes to present in the NN side, and add check 
to make sure our visualization will not exceed these upper limits. Otherwise 
when we have a big namespace an inappropriate depth (set by user) can cause a 
huge memory workload in NN.
                
> Inode tree with snapshot information visualization 
> ---------------------------------------------------
>
>                 Key: HDFS-5066
>                 URL: https://issues.apache.org/jira/browse/HDFS-5066
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Minor
>         Attachments: HDFS-5066.v1.patch, visnap.png
>
>
> It would be nice to be able to visualize snapshot information, in order to 
> ease the understanding of related data structures. We can generate graph from 
> in memory inode links.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to