[ 
https://issues.apache.org/jira/browse/HDFS-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816340#comment-13816340
 ] 

Colin Patrick McCabe commented on HDFS-5468:
--------------------------------------------

+1.

The audit warning is bogus based on it not finding an apache release header on 
some pid files that were left over from a previous jenkins job

> CacheAdmin help command does not recognize commands
> ---------------------------------------------------
>
>                 Key: HDFS-5468
>                 URL: https://issues.apache.org/jira/browse/HDFS-5468
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Stephen Chu
>            Assignee: Stephen Chu
>            Priority: Minor
>         Attachments: HDFS-5468.patch
>
>
> Currently, the hdfs cacheadmin -help command will not recognize correct 
> command inputs:
> {code}
> [hdfs@hdfs-cache ~]# hdfs cacheadmin -help listPools
> Sorry, I don't know the command 'listPools'.
> Valid command names are:
> -addDirective, -removeDirective, -removeDirectives, -listDirectives, 
> -addPool, -modifyPool, -removePool, -listPools, -help
> [hdfs@hdfs-cache ~]# hdfs cacheadmin -help -listPools
> Sorry, I don't know the command 'listPools'.
> Valid command names are:
> -addDirective, -removeDirective, -removeDirectives, -listDirectives, 
> -addPool, -modifyPool, -removePool, -listPools, -help
> {code}
> In the code, we strip the input command of leading hyphens, but then compare 
> it to the command names, which are all prefixed by a hyphen.
> Also, cacheadmin -removeDirectives requires specifying a path with -path but 
> -path is not shown in the usage. We should fix this as well.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to